Skip to content

fix missing manifest when performing multi-platform build and push #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix missing manifest when performing multi-platform build and push #1063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7531b
fix missing manifest when performing multi-platform build and push
jshbrntt Aug 20, 2025
18f4204
Merge branch 'main' into fix/missing-manifest
jshbrntt Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/spec-node/devContainersSpecCLI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,17 @@ async function doBuild({
// Support multiple use of `--label`
params.additionalLabels = (buildxLabel && (Array.isArray(buildxLabel) ? buildxLabel : [buildxLabel]) as string[]) || [];

// Detect multiple platforms for buildx
const platforms = buildxPlatform ? (Array.isArray(buildxPlatform) ? buildxPlatform : String(buildxPlatform).split(',').map(p => p.trim())) : [];
if (platforms.length > 1) {
// For multi-platform builds, force --push and unset --load
params.buildxPush = true;
if (params.buildxOutput === 'load' || params.buildxOutput === '--load') {
params.buildxOutput = undefined;
output && output.write('Warning: --load is not supported for multi-platform builds. Using --push instead.\n');
}
}

if (isDockerFileConfig(config)) {

// Build the base image and extend with features etc.
Expand Down