Remove unused initramfs handler - #969
Open
zjncs wants to merge 1 commit into
Open
Conversation
The task that notified Update-initramfs was removed in dev-sec#591, leaving the handler unreachable. Remove the dead handler to keep the role definition aligned with its execution paths. Fixes dev-sec#911 Signed-off-by: zjncs <18910855655@163.com>
Author
|
The 14 failing Evidence: the failed jobs die while installing collection dependencies from galaxy.ansible.com, before any role task runs, e.g. from the build (rocky10) log: The same galaxy download timeouts also hit the The 22 jobs that did complete (including all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #911
The task that notified the
Update-initramfshandler was removed in #591, but the handler itself was left inroles/os_hardening/handlers/main.yml, making it unreachable dead code.Cause
PR #591 dropped the
update-initramfstask without removing its handler, soroles/os_hardening/handlers/main.ymlkept a handler that nothing can notify anymore.Changes
Update-initramfshandler fromroles/os_hardening/handlers/main.yml(3 lines, no functional change).Verification
3102edd(currentmasterat the time of the change; still the tip ofmaster).grep -rn "initramfs" roles/confirms no remaining task, handler or template references (only historical CHANGELOG entries).Update-initramfs.Risk
Minimal: deleting an unreachable handler cannot change runtime behavior. CI on this PR will run the collection's own lint and molecule checks.
AI assistance disclosure
This patch was prepared by an autonomous AI coding agent at the direction of the account owner, following the repository's contributor guideline (fork, branch, minimal change, DCO sign-off).