feat:smoke test#443
Open
githoboman wants to merge 1 commit into
Open
Conversation
|
@githoboman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proper 7-step lifecycle test:
Closes #99
initialize — handles AlreadyInitialized gracefully (re-deploys are OK)
add_issuer — registers admin as a temporary smoke-test issuer
register_patient — admin plays the patient role (no extra keypair needed — patient.require_auth() is satisfied since patient == admin == tx signer)
mint_vaccination — mints a record and captures the returned token_id
verify_vaccination — asserts vaccinated=true
revoke_vaccination — revokes the record using the captured token_id
verify_vaccination (again) — asserts vaccinated=false
Cleanup: revoke_issuer to remove admin from the issuer list
Supports both stellar and soroban CLI (auto-detected)
Supports STELLAR_NETWORK=mainnet override
Exits non-zero if any step fails; all failures are reported before exit
contracts/Makefile — replaced the single-call inline smoke test with a call to scripts/smoke-test.sh, passing VACCINATIONS_CONTRACT_ID, ADMIN_SECRET_KEY, and ADMIN_PUBLIC_KEY as env vars. The .env write is now done before the smoke test so the file is updated even if the test fails.
.github/workflows/deploy.yml — replaced the inline stellar contract invoke ... verify_vaccination step in both deploy-testnet and deploy-mainnet jobs with bash scripts/smoke-test.sh, setting the required env vars from GitHub secrets.