Feat/266 270 275 276 design audit duplicate#429
Merged
dev-fatima-24 merged 4 commits intoMay 30, 2026
Merged
Conversation
…dit log - Changed audit log writes from synchronous to asynchronous - Prevents blocking request/response cycle - Maintains append-only semantics with no update/delete capability - Logs include timestamp, actor, action, target, result, and metadata - Errors logged to stderr without crashing server - Audit log path configurable via AUDIT_LOG_PATH env var
- Added checkDuplicateRecord() helper to query existing records before minting - Backend checks for duplicates before invoking contract to avoid unnecessary RPC calls - Returns 409 Conflict with existing_token_id if duplicate found - Provides faster, clearer error messages than contract-only detection - Gracefully handles verification failures by falling back to contract check - Audit log records duplicate detection attempts
- Created design tokens file with color, typography, spacing, and shadow tokens
- Defined primary, secondary, success, error, warning, and neutral color palettes
- Each palette includes 10 shades (50-900) for flexible theming
- Added CSS custom properties for all color tokens
- Supports light and dark mode variants
- Consistent naming convention: --color-{category}-{shade}
- Includes semantic aliases for common UI elements
- All components can now reference tokens instead of hardcoded hex values
- Created typography utility file with scale definitions - Defined H1-H4 heading levels with consistent sizing and weights - Established body, body-sm, caption, and label text styles - All typography uses CSS custom properties for consistency - Minimum line height of 1.5 for body text ensures readability - Responsive typography adjustments for mobile (87.5% scale) - Semantic HTML elements (h1-h4, p, small, label) use typography scale - Utility classes (.h1, .h2, etc.) available for non-semantic usage - No ad-hoc font-size values remain in the codebase
|
@Xoulomon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements four critical features for VacciChain's design system, backend audit logging, and data integrity:
Changes
Backend - Audit Logging (#266)
File:
backend/src/middleware/auditLog.jsappendFileSync) to asynchronous (appendFile)timestamp,actor(wallet),action,target,result,metaAUDIT_LOG_PATHenvironment variableAcceptance Criteria:
Backend - Duplicate Detection (#270)
Files:
backend/src/stellar/soroban.js,backend/src/routes/vaccination.jscheckDuplicateRecord()helper to query existing records before mintingexisting_token_idif duplicate foundAcceptance Criteria:
{ error: "Duplicate record", existing_token_id: "..." }Frontend - Color System (#275)
Files:
frontend/src/styles/designTokens.js,frontend/src/index.css--color-{category}-{shade}Acceptance Criteria:
Frontend - Typography Hierarchy (#276)
Files:
frontend/src/styles/typography.js,frontend/src/index.cssAcceptance Criteria:
Testing
Files Changed
backend/src/middleware/auditLog.js(modified)backend/src/stellar/soroban.js(modified)backend/src/routes/vaccination.js(modified)frontend/src/index.css(modified)frontend/src/styles/designTokens.js(new)frontend/src/styles/typography.js(new)Closes #266
Closes #270
Closes #275
Closes #276