Skip to content

Pass along headers to actual (golang) http request #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fwessels wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass along headers to actual (golang) http request #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions fetch/fetch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,23 @@ func DefineWithHandler(vm *otto.Otto, l *loop.Loop, h http.Handler) error {
body = strings.NewReader(jsBody.String())
}

// Make map for headers to pass in
reqHeaders := make(map[string]string)

reqHdrObj := mustValue(jsReq.Get("headers")).Object()
// TODO: Get list of headers from jsReq object (idea: add 'list' method to headers.js?)
// Alternatively: iterate such as in: for (var k in r.headers._headers) { console.log(k + ':', r.headers.get(k)); }
for _, key := range []string{"Authorization" , "X-Amz-Date", "Content-MD5", "Content-Type", "X-Amz-User-Agent", "X-Amz-Content-Sha256"} {

var v otto.Value
var err error
if v, err = reqHdrObj.Call("get", key); err == nil {
if !v.IsNull() && v.String() != "undefined" {
reqHeaders[key] = v.String()
}
}
}

t := &fetchTask{
jsReq: jsReq,
jsRes: jsRes,
Expand All @@ -116,6 +133,10 @@ func DefineWithHandler(vm *otto.Otto, l *loop.Loop, h http.Handler) error {
defer l.Ready(t)

req, err := http.NewRequest(method, urlStr, body)
for k, v := range reqHeaders {
req.Header.Set(k, v) // Set headers
}

if err != nil {
t.err = err
return
Expand Down