Skip to content

Conversation

@crowlKats
Copy link
Member

@crowlKats crowlKats commented Oct 2, 2024

See denoland/deno#25376

To land just before #81

@crowlKats crowlKats mentioned this pull request Oct 2, 2024
@lucacasonato lucacasonato mentioned this pull request Oct 2, 2024
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add this warning until a couple weeks after 2.0 is out.


async function main() {
core.warning(
"Running on setup-deno@1, which is deprecated.\nPlease update to setup-deno@2, which defaults to Deno 2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Running on setup-deno@1, which is deprecated.\nPlease update to setup-deno@2, which defaults to Deno 2.0",
"Running on setup-deno@v1, which is deprecated.\nPlease update to setup-deno@v2, which defaults to Deno 2.0",

Add a link to more info. That link should mention that you can use 1.x with setup-deno@v2`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants