Skip to content

Neon RaiseExceptions configuration parameter passthrough and other fixes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bm-q wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Neon RaiseExceptions configuration parameter passthrough and other fixes #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5e3950c
Merge pull request #2 from delphi-blocks/master
bm-q Jul 8, 2020
d31fa36
Merge pull request #3 from delphi-blocks/master
bm-q Dec 4, 2023
c948de3
Merge pull request #4 from delphi-blocks/master
bm-q Aug 14, 2024
aba4744
Merge pull request #5 from delphi-blocks/master
bm-q Jan 21, 2025
ff382b0
Merge pull request #6 from delphi-blocks/master
bm-q Jun 11, 2025
f36dfc1
Merge branch 'delphi-blocks:master' into master
bm-q Jul 10, 2025
a13d704
Neon RaiseExceptions configuration parameter passthrough
bm-q Jul 11, 2025
8f8a54c
Merge branch 'master' of https://github.com/bm-q/WiRL
bm-q Jul 11, 2025
c9d76cd
Merge branch 'delphi-blocks:master' into master
bm-q Sep 18, 2025
c0354c0
Merge branch 'delphi-blocks:master' into master
bm-q Nov 4, 2025
55d289e
Merge branch 'master' into master
bm-q Nov 4, 2025
22c1994
Merge pull request #8 from delphi-blocks/master
bm-q May 1, 2026
48df999
Fixed a memory leak due to json cloning in exception creation
bm-q May 3, 2026
76f9006
Fixed incorrect assignment of SetErrorDebugInfo value (it was always …
bm-q May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Core/WiRL.Configuration.Errors.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function TWiRLConfigurationErrors.SetErrorClass(AClass: ExceptClass): IWiRLConfi

function TWiRLConfigurationErrors.SetErrorDebugInfo(ADebug: Boolean): IWiRLConfigurationErrors;
begin
FErrorDebugInfo := True;
FErrorDebugInfo := ADebug;
Result := Self;
end;

Expand Down
14 changes: 13 additions & 1 deletion Source/Core/WiRL.Configuration.Neon.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ interface
function SetIgnoreFieldPrefix(AValue: Boolean): IWiRLConfigurationNeon;
function SetUseUTCDate(AValue: Boolean): IWiRLConfigurationNeon;
function SetPrettyPrint(AValue: Boolean): IWiRLConfigurationNeon;
function SetRaiseExceptions(AValue: Boolean): IWiRLConfigurationNeon;
function AddSerializer(ASerializerClass: TCustomSerializerClass): IWiRLConfigurationNeon;
function RemoveSerializer(ASerializerClass: TCustomSerializerClass): IWiRLConfigurationNeon;
end;
Expand All @@ -39,6 +40,7 @@ TWiRLConfigurationNeon = class(TWiRLConfiguration, IWiRLConfigurationNeon)
private
FNeonConfiguration: INeonConfiguration;
FPrettyPrint: Boolean;
FRaiseExceptions: Boolean;
FIgnoreFieldPrefix: Boolean;
FMemberCustomCase: TCaseFunc;
FUseUTCDate: Boolean;
Expand All @@ -63,6 +65,7 @@ TWiRLConfigurationNeon = class(TWiRLConfiguration, IWiRLConfigurationNeon)
function SetIgnoreFieldPrefix(AValue: Boolean): IWiRLConfigurationNeon;
function SetUseUTCDate(AValue: Boolean): IWiRLConfigurationNeon;
function SetPrettyPrint(AValue: Boolean): IWiRLConfigurationNeon;
function SetRaiseExceptions(AValue: Boolean): IWiRLConfigurationNeon;

function AddSerializer(ASerializerClass: TCustomSerializerClass): IWiRLConfigurationNeon;
function RemoveSerializer(ASerializerClass: TCustomSerializerClass): IWiRLConfigurationNeon;
Expand All @@ -78,6 +81,7 @@ TWiRLConfigurationNeon = class(TWiRLConfiguration, IWiRLConfigurationNeon)
property Visibility: TNeonVisibility read FVisibility write FVisibility;
property IgnoreFieldPrefix: Boolean read FIgnoreFieldPrefix write FIgnoreFieldPrefix;
property UseUTCDate: Boolean read FUseUTCDate write FUseUTCDate;
property RaiseExceptions: Boolean read FRaiseExceptions write FRaiseExceptions;
public
property Serializers: TNeonSerializerRegistry read FSerializers write FSerializers;
end;
Expand All @@ -101,7 +105,7 @@ constructor TWiRLConfigurationNeon.Create;
SetVisibility([mvPublic, mvPublished]);
SetUseUTCDate(True);
SetPrettyPrint(False);

SetRaiseExceptions(False);
end;

class function TWiRLConfigurationNeon.Default: IWiRLConfigurationNeon;
Expand Down Expand Up @@ -177,6 +181,7 @@ function TWiRLConfigurationNeon.GetNewNeonConfig: INeonConfiguration;
.SetIgnoreFieldPrefix(FIgnoreFieldPrefix)
.SetUseUTCDate(FUseUTCDate)
.SetPrettyPrint(FPrettyPrint)
.SetRaiseExceptions(FRaiseExceptions)
.GetSerializers
.RegisterSerializer(TJSONValueSerializer)
.RegisterSerializer(TGUIDSerializer)
Expand Down Expand Up @@ -232,6 +237,13 @@ function TWiRLConfigurationNeon.SetPrettyPrint(AValue: Boolean): IWiRLConfigurat
Result := Self;
end;

function TWiRLConfigurationNeon.SetRaiseExceptions(
AValue: Boolean): IWiRLConfigurationNeon;
begin
FRaiseExceptions := AValue;
Result := Self;
end;

function TWiRLConfigurationNeon.SetUseUTCDate(AValue: Boolean): IWiRLConfigurationNeon;
begin
FUseUTCDate := AValue;
Expand Down
14 changes: 7 additions & 7 deletions Source/Core/WiRL.Core.Exceptions.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,7 @@ constructor EWiRLWebApplicationException.Create(const AMessage: string);

constructor EWiRLWebApplicationException.Create(const AMessage: string; AStatus: Integer);
begin
inherited Create(AMessage);
FStatus := AStatus;
FException := ClassName;
FData := TJSONObject.Create;
Create(AMessage, AStatus, nil);
end;

constructor EWiRLWebApplicationException.Create(const AMessage: string;
Expand All @@ -369,10 +366,13 @@ constructor EWiRLWebApplicationException.Create(const AMessage: string;

constructor EWiRLWebApplicationException.Create(const AMessage: string; AStatus: Integer; AData: TJSONObject);
begin
Create(AMessage, AStatus);
inherited Create(AMessage);
FStatus := AStatus;
FException := ClassName;

if Assigned(AData) then
FData := (AData.Clone as TJSONObject);
if Assigned(AData)
then FData := (AData.Clone as TJSONObject)
else FData := TJSONObject.Create;
end;

constructor EWiRLWebApplicationException.Create(AInnerException: Exception;
Expand Down