[MSD-496][test] JEOL METEOR: adjust axes range to match JEOL simulator#3413
Conversation
The new version of the simple JEOL simulator v1.0.7 is more picky about the axes ranges, and more realistic. Z can never go as low as 0. => update the ranges, and positions, and adjust the test case to always stay within the "Base" range.
📝 WalkthroughWalkthroughThis pull request updates the JEOL simulator stage configuration and corresponding test case. The stage simulator travel ranges are narrowed: the X-axis range changes from Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
There was a problem hiding this comment.
Pull request overview
Updates the METEOR JEOL simulator configuration and its movement tests to accommodate stricter axis-range constraints introduced in JEOL simulator v1.0.7 (notably that Z cannot reach 0).
Changes:
- Adjusts the JEOL simulator stage X/Z ranges and related calibration/metadata positions.
- Updates the JEOL movement test to use an initial Z value that stays within the simulator’s allowed range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/odemis/acq/test/move_jeol_test.py |
Updates a test’s initial stage Z to remain within the simulator’s valid range. |
install/linux/usr/share/odemis/sim/meteor-jeol-sim.odm.yaml |
Updates simulator stage limits/calibration and posture ranges/positions to match the newer JEOL simulator constraints. |
The new version of the simple JEOL simulator v1.0.7 is more picky about
the axes ranges, and more realistic. Z can never go as low as 0.
=> update the ranges, and positions, and adjust the test case to always stay within the
"Base" range.