Skip to content

[MSD-496][test] JEOL METEOR: adjust axes range to match JEOL simulator#3413

Open
pieleric wants to merge 1 commit intodelmic:masterfrom
pieleric:test-jeol-meteor-adjust-axes-range-to-match-jeol-simulator
Open

[MSD-496][test] JEOL METEOR: adjust axes range to match JEOL simulator#3413
pieleric wants to merge 1 commit intodelmic:masterfrom
pieleric:test-jeol-meteor-adjust-axes-range-to-match-jeol-simulator

Conversation

@pieleric
Copy link
Member

The new version of the simple JEOL simulator v1.0.7 is more picky about
the axes ranges, and more realistic. Z can never go as low as 0.
=> update the ranges, and positions, and adjust the test case to always stay within the
"Base" range.

The new version of the simple JEOL simulator v1.0.7 is more picky about
the axes ranges, and more realistic. Z can never go as low as 0.
=> update the ranges, and positions, and adjust the test case to always stay within the
"Base" range.
Copilot AI review requested due to automatic review settings March 20, 2026 16:34
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

This pull request updates the JEOL simulator stage configuration and corresponding test case. The stage simulator travel ranges are narrowed: the X-axis range changes from [-55e-3, 10e-3] to [-10e-3, 10e-3], and the Z-axis minimum increases from 0e-3 to 1.5e-3]. Associated metadata values are updated including calibration displacement, imaging range, and deactive position offset. A corresponding test case is adjusted to use a Z-axis value of 4.85e-3 instead of 0.85e-3 to remain within the new stage range constraints.

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for updating axes ranges and test positions to match JEOL simulator v1.0.7's stricter requirements.
Title check ✅ Passed The title accurately describes the main change: adjusting axes ranges in JEOL METEOR tests to match the simulator, which is directly supported by both file modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

@pieleric pieleric requested a review from tmoerkerken March 20, 2026 16:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the METEOR JEOL simulator configuration and its movement tests to accommodate stricter axis-range constraints introduced in JEOL simulator v1.0.7 (notably that Z cannot reach 0).

Changes:

  • Adjusts the JEOL simulator stage X/Z ranges and related calibration/metadata positions.
  • Updates the JEOL movement test to use an initial Z value that stays within the simulator’s allowed range.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/odemis/acq/test/move_jeol_test.py Updates a test’s initial stage Z to remain within the simulator’s valid range.
install/linux/usr/share/odemis/sim/meteor-jeol-sim.odm.yaml Updates simulator stage limits/calibration and posture ranges/positions to match the newer JEOL simulator constraints.

@pieleric pieleric changed the title [test] JEOL METEOR: adjust axes range to match JEOL simulator [MSD-496][test] JEOL METEOR: adjust axes range to match JEOL simulator Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants