Skip to content

[fix] SPARC alignment tab: adjust the tooltips of the Light Out buttons#3397

Open
pieleric wants to merge 1 commit intodelmic:masterfrom
pieleric:fix-sparc-alignment-tab-adjust-the-tooltips-of-the-light-out-buttons
Open

[fix] SPARC alignment tab: adjust the tooltips of the Light Out buttons#3397
pieleric wants to merge 1 commit intodelmic:masterfrom
pieleric:fix-sparc-alignment-tab-adjust-the-tooltips-of-the-light-out-buttons

Conversation

@pieleric
Copy link
Member

@pieleric pieleric commented Mar 6, 2026

The "Retract" and "Engage" buttons had the same tooltips as for the
manual focus mode.
=> Put some proper explanations

The "Retract" and "Engage" buttons had the same tooltips as for the
manual focus mode.
=> Put some proper explanations
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 759eaf67-325b-473c-a377-b028fc8b779a

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5a83f and 9c4ac67.

📒 Files selected for processing (2)
  • src/odemis/gui/main_xrc.py
  • src/odemis/gui/xmlh/resources/panel_tab_sparc2_align.xrc

📝 Walkthrough

Walkthrough

This pull request updates user-facing tooltip text for two selector mirror control buttons across two UI resource files. The "Retract" and "Engage" button tooltips are modified to describe the actual hardware operation—moving the selector mirror to direct light either to the internal spectrograph or out for alignment—replacing previous descriptions referencing manual spectrometer focus functionality. No changes to control logic, layout, properties, or identifiers are made.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adjusting tooltips for Light Out buttons in the SPARC alignment tab, which directly matches the changeset modifications.
Description check ✅ Passed The description is directly related to the changeset, explaining that the Retract and Engage buttons had incorrect tooltips that are now being corrected with proper explanations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SPARC2 alignment “Light Out” UI button tooltips so “Retract” and “Engage” describe the selector mirror behavior instead of reusing manual focus tooltip text.

Changes:

  • Updated “Retract” tooltip text in the SPARC2 alignment XRC resource.
  • Updated “Engage” tooltip text in the SPARC2 alignment XRC resource.
  • Regenerated/updated the corresponding embedded resource XML in main_xrc.py.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/odemis/gui/xmlh/resources/panel_tab_sparc2_align.xrc Replaces incorrect duplicated tooltips for the Light Out “Retract/Engage” buttons with behavior-specific descriptions.
src/odemis/gui/main_xrc.py Updates the auto-generated pywxrc resource output to match the XRC tooltip text changes.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants