[fix] SPARC alignment tab: adjust the tooltips of the Light Out buttons#3397
Conversation
The "Retract" and "Engage" buttons had the same tooltips as for the manual focus mode. => Put some proper explanations
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request updates user-facing tooltip text for two selector mirror control buttons across two UI resource files. The "Retract" and "Engage" button tooltips are modified to describe the actual hardware operation—moving the selector mirror to direct light either to the internal spectrograph or out for alignment—replacing previous descriptions referencing manual spectrometer focus functionality. No changes to control logic, layout, properties, or identifiers are made. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the SPARC2 alignment “Light Out” UI button tooltips so “Retract” and “Engage” describe the selector mirror behavior instead of reusing manual focus tooltip text.
Changes:
- Updated “Retract” tooltip text in the SPARC2 alignment XRC resource.
- Updated “Engage” tooltip text in the SPARC2 alignment XRC resource.
- Regenerated/updated the corresponding embedded resource XML in
main_xrc.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/odemis/gui/xmlh/resources/panel_tab_sparc2_align.xrc |
Replaces incorrect duplicated tooltips for the Light Out “Retract/Engage” buttons with behavior-specific descriptions. |
src/odemis/gui/main_xrc.py |
Updates the auto-generated pywxrc resource output to match the XRC tooltip text changes. |
You can also share your feedback on Copilot code review. Take the survey.
The "Retract" and "Engage" buttons had the same tooltips as for the
manual focus mode.
=> Put some proper explanations