Skip to content

Optimize handler method lookup to avoid repeated inheritance chain traversal #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkholt merged 3 commits into from
Nov 26, 2025
Merged

Optimize handler method lookup to avoid repeated inheritance chain traversal #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c809f7c
Initial plan
Copilot Nov 26, 2025
6fb1d9e
REFACTOR: Materialize inheritance chain results for better caching
Copilot Nov 26, 2025
0eb476b
Merge parent branch to resolve build error
Copilot Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions XrmPluginCore.SourceGenerator/Validation/HandlerMethodValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,20 @@ public static void ValidateHandlerMethod(
}
}

private static IEnumerable<IMethodSymbol> GetAllMethodsIncludingInherited(ITypeSymbol type, string methodName)
private static IReadOnlyList<IMethodSymbol> GetAllMethodsIncludingInherited(ITypeSymbol type, string methodName)
{
var methods = new List<IMethodSymbol>();
var currentType = type;
while (currentType is not null)
{
foreach (var member in currentType.GetMembers(methodName))
{
if (member is IMethodSymbol method)
yield return method;
methods.Add(method);
}
currentType = currentType.BaseType;
}
return methods;
}

private static bool SignatureMatches(IMethodSymbol method, bool hasPreImage, bool hasPostImage)
Expand Down