feat: add support for delete_all_documents for astra client

[srini047]

Related Issues

• fixes add delete_all_documents() operation to AstraDocumentStore #2308

Proposed Changes:

• Added support for delete_all_documents() in document_stort and client
• Removed the delete_all from the delete() to decouple
• Some generic cleanup of the integration

How did you test it?

• Run complete integration test for Astra integration

cd integrations/astra
hatch run test:integration

• Make use of delete_all_documents() where delete(delete_all=True) was used earlier

Notes for the reviewer

A quick question: This is a breaking change do we still need the backward compatibility?

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

[mpangrazzi]

Thanks for your work! I left some comments.

In addition, I see there is no error handling logic here, i.e. no try / catch login if delete_all_documents fails. Please have a look at other implementation and update tests / PR.

[mpangrazzi]

This logging logic can be improved. What about removing this in favour of something like:

logger.info(f"{deletion_counter} documents deleted")

[srini047]

@mpangrazzi The reason for this if-else was -1 which is the response provided by Astra client for successful delete all documents. But in general for a user mindset -1 would mean a error code. Hence I wanted to give a message instead of a counter value returned by Astra.

[mpangrazzi]

@srini047 Got it! So in this case I would do a better error handling: logging it with proper level (i.e. error), get the message (is it available somewhere?). WDYT?

[srini047]

@mpangrazzi This is the response from the Astra API. There's something called raw_result attribute but don't think it has a definite string/msg that we can parse and notify the user with actual error.

We should be handling it from our end but anyways don't have enough data to share with users. So I think this should be fine.

[srini047]

Just changed the verbosity level.

[mpangrazzi]

LGTM!