Ensure "done" callback is invoked if zero-length paths array is provided#60
Open
revetkn wants to merge 1 commit intoded:masterfrom
Open
Ensure "done" callback is invoked if zero-length paths array is provided#60revetkn wants to merge 1 commit intoded:masterfrom
revetkn wants to merge 1 commit intoded:masterfrom
Conversation
Owner
|
interesting, i'll have a stab at getting this in one way or another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is uncommon but possible for script.js to be invoked with [] paths. Current behavior is to never fire the "done" callback, this fix ensures it's called immediately and skips the setTimeout.
Github's diff is a bit misleading - it shows mostly whitespace. I've only added a one-line if statement.