Open
Conversation
Member
JoeGruffins
commented
Feb 16, 2026
- Fix XSS risk: remove html.WithUnsafe() from goldmark renderer
- Fix SignMessage to decode base64 signature from RPC wallet
- Fix iterateTable swallowing errors (return nil -> return err)
- Make politeia init non-fatal so wallet still runs without it
- Add nil guards for c.politeia in all core politeia methods
- Move table/index setup after version check to avoid DropAll issues
- Add nil Vote check before dereferencing in CastVotes
- Fix division by zero when EligibleTickets is 0
- Fix lastSync stored on error (move from defer to after success)
- Fix swallowed error in spv AddressAccount
- Fix copy-paste error in proposalTokenCtx (host -> token)
- Make ProposalsInProgress failure non-fatal in apiStakeStatus
- Add bounds check before proposals[0] access
- Fix IsEqual to compare all meaningful fields
- Fix CSS selector bugs: missing commas, incorrect nesting
- Fix typos: politiaSyncing, nTicketAddresess, --text-sucess
- Fix async/await on loadPage calls in TypeScript
- Fix null safety for proposalsInProgress in wallets.ts
- Fix duplicate &status= in proposals pagination link
- Fix loadProposal query string format in wallets.ts
- Remove dead voteBitVerify function and unused imports
- Remove pre-selected active class on Yes vote button
- Rename versionTxt -> idVersionTxt for naming consistency
- Scope .card CSS override to proposal pages only
- Remove stale storm tags and dcrdata references
Address bugs, safety issues, and code quality problems identified during review of the politeia governance voting integration: - Fix XSS risk: remove html.WithUnsafe() from goldmark renderer - Fix SignMessage to decode base64 signature from RPC wallet - Fix iterateTable swallowing errors (return nil -> return err) - Make politeia init non-fatal so wallet still runs without it - Add nil guards for c.politeia in all core politeia methods - Move table/index setup after version check to avoid DropAll issues - Add nil Vote check before dereferencing in CastVotes - Fix division by zero when EligibleTickets is 0 - Fix lastSync stored on error (move from defer to after success) - Fix swallowed error in spv AddressAccount - Fix copy-paste error in proposalTokenCtx (host -> token) - Make ProposalsInProgress failure non-fatal in apiStakeStatus - Add bounds check before proposals[0] access - Fix IsEqual to compare all meaningful fields - Fix CSS selector bugs: missing commas, incorrect nesting - Fix typos: politiaSyncing, nTicketAddresess, --text-sucess - Fix async/await on loadPage calls in TypeScript - Fix null safety for proposalsInProgress in wallets.ts - Fix duplicate &status= in proposals pagination link - Fix loadProposal query string format in wallets.ts - Remove dead voteBitVerify function and unused imports - Remove pre-selected active class on Yes vote button - Rename versionTxt -> idVersionTxt for naming consistency - Scope .card CSS override to proposal pages only - Remove stale storm tags and dcrdata references
ac9986c to
179853e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.