Shellcheck some count scripts

servers/scripts/check-failed.sh

@@ -1,3 +1,3 @@
 #!/bin/sh
 FAILED_SQL=$HOME/servers/failed_sql.sql
-test -e $FAILED_SQL && echo "$(wc -l $FAILED_SQL)"
+test -e "$FAILED_SQL" && wc -l "$FAILED_SQL"

servers/scripts/client-countries-today.sh

@@ -1,2 +1,11 @@
 #!/bin/sh
-cat /home/teeworlds/servers/versionsrv.log | grep -a "^\[`date +%y-%m-%d`" | grep "version request by" | sed -e "s/.*by //" | sort | uniq | while read line; do geoiplookup $line; done | sort | uniq -c | sort -gr
+
+grep -a "^\[$(date +%y-%m-%d)" /home/teeworlds/servers/versionsrv.log | \
+    grep "version request by" | \
+    sed -e "s/.*by //" | \
+    sort | \
+    uniq | while read -r line; \
+    do
+        geoiplookup "$line";
+    done | sort | uniq -c | sort -gr
+

servers/scripts/client-countries-yesterday.sh

@@ -1,2 +1,11 @@
 #!/bin/sh
-cat /home/teeworlds/servers/versionsrv.log | grep -a "^\[`date --date='1 days ago' +%y-%m-%d`" | grep "version request by" | sed -e "s/.*by //" | sort | uniq | while read line; do geoiplookup $line; done | sort | uniq -c | sort -gr
+
+grep -a "^\[$(date --date='1 days ago' +%y-%m-%d)" /home/teeworlds/servers/versionsrv.log | \
+    grep "version request by" | \
+    sed -e "s/.*by //" | \
+    sort | \
+    uniq | while read -r line; \
+    do
+        geoiplookup "$line";
+    done | sort | uniq -c | sort -gr
+

servers/scripts/client-players-today.sh

@@ -1,2 +1,6 @@
 #!/bin/sh
-cat /home/teeworlds/servers/versionsrv.log | grep -a "^\[`date +%Y-%m-%d`" | grep "version request by" | sed -e "s/.*by //" | sort | uniq | wc -l
+grep -a "^\[$(date +%Y-%m-%d)" /home/teeworlds/servers/versionsrv.log | \
+    grep "version request by" | \
+    sed -e "s/.*by //" | \
+    sort | uniq | wc -l
+

servers/scripts/client-players-yesterday.sh

@@ -1,2 +1,7 @@
 #!/bin/sh
-cat /home/teeworlds/servers/versionsrv.log | grep -a "^\[`date --date='1 days ago' +%Y-%m-%d`" | grep "version request by" | sed -e "s/.*by //" | sort | uniq | wc -l
+
+grep -a "^\[$(date --date='1 days ago' +%Y-%m-%d)" /home/teeworlds/servers/versionsrv.log | \
+    grep "version request by" | \
+    sed -e "s/.*by //" | \
+    sort | uniq | wc -l
+

servers/scripts/countries-today.sh

@@ -1,2 +1,11 @@
 #!/bin/sh
-cat /home/teeworlds/servers/servers/*log* | grep "^\[`date +%y-%m-%d`" | grep "player has entered the game" | sed -e "s/.*addr=\(.*\):.*/\1/" | sort | uniq | while read line; do geoiplookup $line; done | sort | uniq -c | sort -gr
+
+cat /home/teeworlds/servers/servers/*log* | \
+    grep "^\[$(date +%y-%m-%d)" | \
+    grep "player has entered the game" | \
+    sed -e "s/.*addr=\(.*\):.*/\1/" | \
+    sort | uniq | while read -r line;
+    do
+        geoiplookup "$line";
+    done | sort | uniq -c | sort -gr
+

servers/scripts/countries-yesterday.sh

@@ -1,2 +1,11 @@
 #!/bin/sh
-cat /home/teeworlds/servers/servers/*log* | grep "^\[`date --date='1 days ago' +%y-%m-%d`" | grep "player has entered the game" | sed -e "s/.*addr=\(.*\):.*/\1/" | sort | uniq | while read line; do geoiplookup $line; done | sort | uniq -c | sort -gr
+cat /home/teeworlds/servers/servers/*log* | \
+    grep "^\[$(date --date='1 days ago' +%y-%m-%d)" | \
+    grep "player has entered the game" | \
+    sed -e "s/.*addr=\(.*\):.*/\1/" | \
+    sort | \
+    uniq | while read -r line;
+    do
+        geoiplookup "$line";
+    done | sort | uniq -c | sort -gr
+

servers/scripts/players-today.sh

@@ -1,2 +1,8 @@
 #!/bin/sh
-cat /home/teeworlds/servers/servers/*log* | grep -a "^\[`date +%Y-%m-%d`" | grep "player has entered the game" | sed -e "s/.*addr=\(.*\):.*/\1/" | sort | uniq | wc -l
+
+cat /home/teeworlds/servers/servers/*log* | \
+    grep -a "^\[$(date +%Y-%m-%d)" | \
+    grep "player has entered the game" | \
+    sed -e "s/.*addr=\(.*\):.*/\1/" | \
+    sort | uniq | wc -l
+

servers/scripts/players-yesterday.sh

@@ -1,2 +1,7 @@
 #!/bin/sh
-cat /home/teeworlds/servers/servers/*log* | grep -a "^\[`date --date='1 days ago' +%Y-%m-%d`" | grep "player has entered the game" | sed -e "s/.*addr=\(.*\):.*/\1/" | sort | uniq | wc -l
+cat /home/teeworlds/servers/servers/*log* | \
+    grep -a "^\[$(date --date='1 days ago' +%Y-%m-%d)" | \
+    grep "player has entered the game" | \
+    sed -e "s/.*addr=\(.*\):.*/\1/" | \
+    sort | uniq | wc -l
+

servers/scripts/rebuild-votes.sh

@@ -1,7 +1,8 @@
 #!/bin/sh
 
-for t in `cat all-types`; do
-  tl=$(echo "$t" | tr A-Z a-z)
-  /home/django/bin/print_mapfile $t > "/home/teeworlds/servers/types/$tl/maps"
-done
+while IFS= read -r t
+do
+  tl=$(echo "$t" | tr '[:upper:]' '[:lower:]')
+  /home/django/bin/print_mapfile "$t" > "/home/teeworlds/servers/types/$tl/maps"
+done < all-types
 

servers/scripts/update-everything.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 
-cd /home/teeworlds/servers
+cd /home/teeworlds/servers || exit 1
 
-if [ $(cat /proc/loadavg|head -c1) -ge 2 ]; then
+if [ "$(head -c1 /proc/loadavg)" -ge 2 ]; then
   #echo -e "Current load is > 2, not running."
   exit 1
 fi
@@ -22,15 +22,15 @@ cleanup()
 
 trap cleanup EXIT HUP INT QUIT TERM # Always call, even on success.
 
-types=`cat all-types`
+types=$(cat all-types)
 
 scripts/update-local.sh
 
 scripts/ranks.py $types
 # Only update the country-specific pages once per day
 #if test `find /var/www/ranks/ger/novice/index.html -mmin +1440`; then
-  grep name serverlist.json | sed -e 's/.*"name": "\(.*\)".*/\1/' | while read country; do
-    scripts/ranks.py --country=$country $types
+  grep name serverlist.json | sed -e 's/.*"name": "\(.*\)".*/\1/' | while read -r country; do
+    scripts/ranks.py --country="$country" $types
   done
 #fi
 

servers/scripts/update-old-countries.sh

@@ -1,9 +1,9 @@
 #!/bin/bash
 
-cd /home/teeworlds/servers
+cd /home/teeworlds/servers || exit 1
 
-countries=`cat all-old-countries`
-types=`cat all-types`
+countries=$(cat all-old-countries)
+types=$(cat all-types)
 for country in $countries; do
-  scripts/ranks.py --country=$country $types
+  scripts/ranks.py --country="$country" $types
 done