Allow multiple parallel connections to Selenium #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know I’ve arrived late to the party, but of course, no objections; great improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
By default, only one connection to the Selenium instance inside the container is allowed. Therefore, if a Nightwatch test run process gets a fatal error, you can't run other tests for several seconds or even minutes, which is very inconvenient!
How This PR Solves The Issue
Enables up to 12 parallel connections to make the new Nightwatch test always find a free connection to start executing.
Manual Testing Instructions
Automated Testing Overview
Seems we have no tests for Selenium and Nightwatch?
Release/Deployment Notes
Allowed multiple parallel connections to Selenium