Repository navigation
Fix drupal-contrib D12 tests tracking a frozen alpha tag instead of core HEAD - #212
Merged
Merged
Conversation
…ore HEAD The D12 test cell resolves drupal/core via a "^12" constraint, which Composer's prefer-stable logic always resolves to the latest tagged prerelease (currently 12.0.0-alpha1, frozen at 2 Sep 2026) rather than the continuously-updated 12.0.x dev branch. This caused CI to keep failing on a Twig 3.30 TypeError (drupal.org #3625969) for weeks after the fix landed on 12.0.x, because no new prerelease tag had been cut. Use an explicit "12.x-dev" constraint for version 12, which Composer always honors regardless of prefer-stable/minimum-stability, so this cell tracks core HEAD as intended. Versions 10/11 are unaffected since they have real stable tagged releases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
rfay
added a commit
that referenced
this pull request
Sep 27, 2026
…#216 The new phpunit CI step added earlier in this branch failed on the "Contrib skipto D12 (plain, GH)" cell with "Cannot open bootstrap script core/tests/bootstrap.php": https://github.com/ddev/coder-ddev/actions/runs/36280470996/job/108511195288 drupal_version=12 has no stable tag yet, so it resolves to the 12.x-dev branch (see #212). Composer's default dist install for a -dev/branch version fetches a GitHub zipball, which is a git-archive snapshot honoring drupal/core's own .gitattributes export-ignore rules -- and those strip core/tests entirely. D10/D11 are unaffected since they resolve to real tagged releases, whose dist packages aren't built this way. Verified: a plain `git clone` of the same ref includes tests/, and forcing `composer config preferred-install.drupal/core source` (so Composer does a real clone instead of downloading the zipball) fixes it end-to-end -- confirmed core/tests present and the CI smoke test (`ddev phpunit web/core/modules/system/tests/src/Functional/System/PageTitleTest.php`) passing on a fresh workspace. Set that config only for drupal_version=12, before `ddev poser` runs; D10/D11 are untouched since forcing source there would only slow down every install for no benefit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drupal/corevia a^12Composer constraint, which — combined withexpand_composer_json.php'sprefer-stable=true— always picks the latest tagged prerelease (currently12.0.0-alpha1, frozen at 2 Sep 2026) instead of the continuously-updated12.0.xdev branch.EscaperRuntime::escape()TypeError (drupal.org #3625969) for weeks after the fix landed on12.0.x, since no new prerelease tag had been cut to carry it forward. See run 36273741979.12.x-devconstraint fordrupal_version=12, which Composer always honors regardless ofprefer-stable/minimum-stability, so this cell actually tracks core HEAD as its workflow comment claims. Versions 10/11 are untouched since they have real stable tagged releases.Test plan
terraform fmt -recursive(no changes needed beyond the edit)make validate— all templates validmake test-templates— all templates pass (13/13, 13/13, 18/18)Contrib skipto D12 (plain, GH)job in CI now installs a12.0.x-devcore build past commit836a5ba6and passes🤖 Generated with Claude Code