Open
Conversation
|
This now sets three environment variables and removed them immediately afterwards. No? Also, abseil is not built anymore because S2 is removed. Cheers, |
Contributor
Author
|
If David wanted to permanently remove sf from the image I assume he would have done so instead of commenting it out, so I followed his lead and commented out s2 so it can be easily re-enabled in the future. During the time these packages are commented out, the variables are just set and then immediately unset as you say, but keeping them there avoids muddling |
Abseil is a C++ library, so that does not use the settings from R's Makevars. Set some variables so CMake starts using ccache, which makes local image builds with a warm cache quite a bit faster.
This is required by sf, which is disabled, so disable this to speed up the image build.
pjonsson
force-pushed
the
docker-ccache-s2
branch
from
c5294c8 to
3f60334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abseil is a C++ library, so that does
not use the settings from
R's Makevars. Set some variables
so CMake starts using ccache, which
makes local image builds with
a warm cache quite a bit faster.
Also disable the s2 build per #13 (comment) since that is only required by sf.