Adding an updated notebook manager implementation for ipython 2.x#5
Open
gf-atebbe wants to merge 2 commits intodavidbrai:masterfrom
Open
Adding an updated notebook manager implementation for ipython 2.x#5gf-atebbe wants to merge 2 commits intodavidbrai:masterfrom
gf-atebbe wants to merge 2 commits intodavidbrai:masterfrom
Conversation
Owner
|
@gf-atebbe thanks for the pull request. I'll review it in the next few days! |
|
Any progress on this issue? |
Owner
|
Hi @fatlotus, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you're interested in accepting this on a separate branch from master but I used the simple notebook manager as a reference and implemented the notebook manager class for ipython 2.x. Testing has been a bit minimal still and there's plenty of room for improvement since I overrode some methods in the base class that I probably didn't have to but I figured its a start....