Exit script on failed command. Plus minor changes#12
Open
mgymrek wants to merge 6 commits into
Open
Conversation
added 6 commits
January 7, 2016 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to make scripts fail when
subprocess.call(cmd, shell=True)returns a non-zero exit status. In most cases it doesn't make sense for the scripts to go any further in those cases. There are a couple other minor changes:-wto theinstall_dependencies.pyandinstall_data.pyscripts that allows the script to proceed even if one of the commands failes--no-cudatoinstall_dependencies.pysince as far as I can tell installinginndoesn't work unless CUDA is installed.utils.pyfile with a helpful function for printing progress and error messagesbasset_sad.pywhich should bealt_predrather thanalt predsnps_seq1to reflect that it also outputs raw sequences.