Open
Conversation
On py3 the JWT token are `bytes` and if sent as is it gets sent as `b'exdf...'`. Giftless can't decode it and the download fails.
Member
|
@pdelboca We need to fix the GitHub pipeline, apart from that LGTM. |
shubham-mahajan
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for CKAN 2.10 and drops support for CKAN 2.8 and Python 2.7 since they will no longer by maintained by the CKAN community. (Starting CKAN 2.10).
It also modernizes the
test.yamltemplate to use a common approach with all CKAN extensions.