JS/CSS resource loading compatibility for both 2.8 and 2.9 ckan version.#62
Open
sagargg-zz wants to merge 2 commits intomasterfrom
Open
JS/CSS resource loading compatibility for both 2.8 and 2.9 ckan version.#62sagargg-zz wants to merge 2 commits intomasterfrom
sagargg-zz wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
Thanks for this change @sagargg-zz . It was a great help in my project which uses blobstorage and CKAN 2.9 (which depricated fanstatic support with 2.9.3 release). It'd be great to have it merged to the original repo. |
Contributor
|
You might also want to have a look at some changes I needed to do in order to make it work with CKAN 2.9.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CKAN v2.9 doesn’t support resource js/css imports. This PR includes both resource and assets importer so that it will compatible with both v2.9 and v2.8.