Skip to content
This repository was archived by the owner on Sep 13, 2021. It is now read-only.

defaultColors, small changes#43

Draft
elanals wants to merge 9 commits into
masterfrom
defaultColors
Draft

defaultColors, small changes#43
elanals wants to merge 9 commits into
masterfrom
defaultColors

Conversation

@elanals

@elanals elanals commented Dec 9, 2020

Copy link
Copy Markdown
Contributor
  • Removed the logic of blendRatio depending on the background
  • Decreased default for value labels and 'primary' ticks (have been unhappy with these for a while - they got lighter a while ago when switching from d3's interpolateRgb to chroma , so i thought I'd take the chance.
  • Fallback in case theme.colors.background is undefined

@elanals elanals requested a review from gka December 9, 2020 18:40
@elanals elanals marked this pull request as draft May 26, 2021 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gka gka gka approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elanals @gka