Skip to content

Conversation

@timcadman
Copy link
Contributor

@timcadman timcadman commented Oct 9, 2025

Description

  • Remove checks exists and isDefined
  • Written tests that correct error messages are returned

Checklist (not all may apply)

Refactor

  • Remove exists and isDefined and add appropriate checks on server-side
  • Remove code checking whether an object has been successfully created
  • Review code to determine if additional refactoring could reduce calls to server-side package

Testing

  • Writen client-side unit tests for unhappy flow
  • Run and passed devtools::test(filter = "smk-|disc|arg")
  • Run and passed devtools::check(args = '--no-tests') (we run tests separately to skip performance checks)
  • Run and passed devtools::build

@StuartWheater
Copy link
Member

I would try devtools::test(filter = "smk-|disc-|discctrl-|arg-") also adding "datachk-" if you wish to check test data sets.

@StuartWheater StuartWheater changed the base branch from master to v7.0-dev October 28, 2025 23:55
@timcadman timcadman merged commit 020b172 into v7.0-dev Nov 25, 2025
1 of 3 checks passed
@timcadman timcadman deleted the v7.0-dev-feat/performance branch November 25, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants