-
Notifications
You must be signed in to change notification settings - Fork 25
Update documentation prior to RC for CRAN #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do we need to also run |
…HIELD >> 'DataSHIELD'. Update title to align with the title for 'dsBase'
…e reference as the current dsBaseClient should exist) and install it
…ll request identifier, when the workflow is triggered by a PR
|
Are the 'git actions' test failing significant? |
|
Does "spelling" need to be added to DESCRIPTION's "Suggests" section |
StuartWheater
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Does a line containing ^.github$ need to be added to the .Rbuildignore file?
- Are the 'git actions' test failing significant?
- Does "spelling" need to be added to DESCRIPTION's "Suggests" section
The issue with Windows has been solved, but with other runners, like Ubuntu, the issue seems to be that I have updated the .Rbuildignore to ignore the |
|
Is "the issue seems to be that dsBase is not found by the installation" going to affect a users experience? |
The introduction of the GitHub Action workflows should not affect the users' experience, this is mostly to automate the checks we do. So, I'm thinking I have probably missed something obvious, like configuring a server in the yaml file. Perhaps we drop the GitHub standard test workflow, so we can get an RC. |
|
Can we disable/skip those tests? |
dsBase's README