Skip to content

Conversation

@timcadman
Copy link
Contributor

This function is a replacement to ds.dataFrameFill. It should be much quicker, and offers additional flexibility in that the user can chose to also set the class of variables to be the same across cohorts and similarly the levels of factor variables.

Changes made

  • Added function ds.standardiseDf
  • Added lifecycle package to handle deprecation of functions
  • Deprecated function ds.dataFrameFill
  • Add tests for ds.standardiseDf
  • Added helper test file which is used in above tests

To test

  • Connect to a real life server, and run the tests test-standardise-df.R excluding the setup for dsLite at the start.

@timcadman timcadman changed the base branch from master to v6.4.0-dev November 8, 2024 15:13
@StuartWheater
Copy link
Member

Does this PR need some tweaking?
Its CI didn't look right?

@timcadman timcadman force-pushed the origin/v6.4.0-dev-feat/standardise-df branch from 717157d to 6c405a6 Compare June 10, 2025 09:47
@timcadman timcadman force-pushed the origin/v6.4.0-dev-feat/standardise-df branch from f50e2bf to 3a31038 Compare June 10, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants