Skip to content

Conversation

@timcadman
Copy link

@timcadman timcadman commented Oct 9, 2025

Instructions & checklist for PR author

Description of changes

  • Refactored colnamesDS to include checks (that will be removed from the client-side function.
  • Added two helper functions in R/utils: .loadServersideObject() and .checkClass()
  • These helper functions can be reused when refactoring other functions

Refactor instructions

  • Replaced x <- eval(parse(text = x.name), envir = parent.frame()) with x <- .loadServersideObject(x)
  • If necessary, check the class of the object using .checkClass()

Testing instructions

  • Writen server-side unit tests for unhappy flow
  • Run devtools::test(filter = "smk-|disc|arg") and check it passes
  • Run devtools::check(args = '--no-tests') and check it passes (we run tests separately to skip performance checks)
  • Run devtools::build() and check it builds without errors

Instructions & checklist for PR reviewers

  • Code review
  • Run devtools::test(filter = "smk-|disc|arg") and check it passes
  • Run devtools::check(args = '--no-tests') and check it passes (we run tests separately to skip performance checks)
  • Run devtools::build() and check it builds without errors

@timcadman timcadman marked this pull request as ready for review October 9, 2025 12:57
@StuartWheater StuartWheater changed the base branch from master to v7.0-dev October 28, 2025 19:27
@timcadman timcadman changed the title V7.0 dev feat/performance refactor/colnamesDS Nov 25, 2025
@timcadman timcadman changed the title refactor/colnamesDS V7.0 dev colnamesDS Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants