Add null guard for weak reference entries in preRollback()#532
Open
jasper-vandemalle wants to merge 2 commits intodatanucleus:masterfrom
Open
Add null guard for weak reference entries in preRollback()#532jasper-vandemalle wants to merge 2 commits intodatanucleus:masterfrom
jasper-vandemalle wants to merge 2 commits intodatanucleus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a null check in the
preRollback()iteration overenlistedSMCachevalues.enlistedSMCacheis aConcurrentReferenceHashMapwithReferenceType.WEAKvalues, so the GC can clear entries at any time. DuringpreRollback()iteration, a cleared weak reference causes the iterator to returnnull, and the subsequentsm.preRollback()call throws NPE.Fix: null guard with
continue. No error logging, because this is an expected race condition with weak references, not an error.Fixes #531
Test:
ExecutionContextNullSMGuardTestinjects a null entry into the cache via reflection and verifiespreRollback()completes without NPE.