-
Notifications
You must be signed in to change notification settings - Fork 63
Workbook access dialog #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Workbook access dialog #3022
Conversation
|
📦 Statoscope quick diff with main-branch: ⏱ Build time: 5.3 sec (10.42%) ⚖️ Initial size: 0.17 kb (0%) 🕵️ Validation errors: 0 Full Statoscope report could be found here |
|
|
|
|
…actions, update access dialog translations, and enhance invitation types
|
i18n-check |
|
i18n-check |
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
| "toast_switch-publication-status-failed": "Не удалось изменить публичный доступ", | ||
| "toast_switch-publication-status-success": "Публичный доступ был изменен" | ||
| "toast_switch-publication-status-success": "Публичный доступ был изменен", | ||
| "label_public-access-warning-title": "Вы даете доступ ко всем выбранным связанным объектам", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no code in the opesource repo that uses these keys. Plz add a separate keyset for the new access dialog in the same repo where this keyset are used.
| ResendInvitationRequest, | ||
| } from '../types/invitations'; | ||
|
|
||
| export const organizationManager = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we declare these actions in the opensource repo? We don't use them here.
| federation?: unknown; | ||
| pictureData?: string; | ||
| idpType?: string | null; | ||
| displayName?: string | React.ReactNode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SubjectClaims is used in BatchListMembersResponse, which is used by the schema action as return type. How schema action (fetch request) can return React.ReactNode?
If such model creates in UI, the customized type should be placed in the ui folder (even types). Imports from react should not be used in shared.
| @@ -0,0 +1 @@ | |||
| export type OpenAccessDialog = (arg: any) => void; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
|
|
||
| export type AclSubjectProps = { | ||
| subjectClaims: SubjectClaims; | ||
| iconSlot?: React.ReactNode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it used somewhere?
| avatarData?: string; | ||
| } & Omit<SubjectClaims, 'sub' | 'subType'>; | ||
|
|
||
| export interface AclSubjectSelectProps extends Omit<AclSubjectSuggestProps, 'onSubjectChange'> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is not related to opensource repo. Is this declared here only because we don't have its own registry in extensions?
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
|
i18n-check Errors occurred when merging changes from your branch with the Weblate branch.Resolve conflicts according to instructions
|
No description provided.