Skip to content

Conversation

@YankinA
Copy link
Contributor

@YankinA YankinA commented Oct 15, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

📦 Statoscope quick diff with main-branch:

⏱ Build time: 5.3 sec (10.42%)

⚖️ Initial size: 0.17 kb (0%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@github-actions
Copy link

E2E Tests

Playwright test results

passed  182 passed
flaky  5 flaky
skipped  2 skipped

Details

stats  189 tests across 105 suites
duration  6 minutes, 17 seconds
commit  e900dbb

Flaky tests

opensource › opensource-suites/connections/clickhouse.test.ts › Clickhouse connector interactions › Connector should be created
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Dataset selectors affect each other before applying when auto-update is enabled
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › The parameterized field should affect the chart
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


👉 Link with detailed report: report

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

E2E Tests

Playwright test results

passed  193 passed
flaky  4 flaky
skipped  2 skipped

Details

stats  199 tests across 109 suites
duration  3 minutes, 6 seconds
commit  b427809

Flaky tests

opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Connector should be created
opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Client validation errors should be displayed after creation attempt
opensource › opensource-suites/wizard/visualizations/flat-table/totals.test.ts › Wizard › Flat table › Totals with no-data
opensource › opensource-suites/wizard/visualizations/metric/color.test.ts › Wizard › Metric chart › Client palette

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-01 10:06:02 MSK

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

E2E Tests No Auth

Playwright test results

passed  191 passed
flaky  6 flaky
skipped  2 skipped

Details

stats  199 tests across 109 suites
duration  2 minutes, 55 seconds
commit  b427809

Flaky tests

opensource › opensource-suites/connections/ytsaurus.test.ts › YTsaurus connector interactions › Client validation errors should be displayed after creation attempt
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › The parameterized field should affect the chart
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/bar-y/grouping.test.ts › Wizard › Bar-y chart › Grouping by Measure Names @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/totals.test.ts › Wizard › Pivot table › Subtotals for Columns @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-01 10:04:35 MSK

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

E2E Tests Farm

Playwright test results

passed  419 passed
flaky  6 flaky
skipped  1 skipped

Details

stats  426 tests across 171 suites
duration  5 minutes, 8 seconds
commit  b427809

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Ql - Export menu item is disabled if export is forbidden on connection
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]
basic › suites/wizard/placeholder-settings/autoScale.test.ts › Wizard - placeholder dialog ("Autoscaling") › If there is a field in "Y" and "Y2", then you can adjust the scaling for each axis separately

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets


👉 Link with detailed report: report

Last updated: 2025-12-01 10:10:02 MSK

@YankinA YankinA requested a review from imsitnikov November 5, 2025 14:50
@YankinA YankinA marked this pull request as ready for review November 14, 2025 09:54
@datalens-weblate-robot
Copy link
Contributor

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

@datalens-weblate-robot
Copy link
Contributor

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

"toast_switch-publication-status-failed": "Не удалось изменить публичный доступ",
"toast_switch-publication-status-success": "Публичный доступ был изменен"
"toast_switch-publication-status-success": "Публичный доступ был изменен",
"label_public-access-warning-title": "Вы даете доступ ко всем выбранным связанным объектам",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no code in the opesource repo that uses these keys. Plz add a separate keyset for the new access dialog in the same repo where this keyset are used.

ResendInvitationRequest,
} from '../types/invitations';

export const organizationManager = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we declare these actions in the opensource repo? We don't use them here.

federation?: unknown;
pictureData?: string;
idpType?: string | null;
displayName?: string | React.ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SubjectClaims is used in BatchListMembersResponse, which is used by the schema action as return type. How schema action (fetch request) can return React.ReactNode?

If such model creates in UI, the customized type should be placed in the ui folder (even types). Imports from react should not be used in shared.

@@ -0,0 +1 @@
export type OpenAccessDialog = (arg: any) => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used


export type AclSubjectProps = {
subjectClaims: SubjectClaims;
iconSlot?: React.ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used somewhere?

avatarData?: string;
} & Omit<SubjectClaims, 'sub' | 'subType'>;

export interface AclSubjectSelectProps extends Omit<AclSubjectSuggestProps, 'onSubjectChange'> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is not related to opensource repo. Is this declared here only because we don't have its own registry in extensions?

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

@datalens-weblate-robot
Copy link
Contributor

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.
Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

  1. Switch to the current branch associated with this pull request.
git checkout CHARTS-11939-access-dialog
  1. Add Weblate as remote. And remove previous upstream with the same name:
git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate
  1. Merge Weblate changes:
git merge weblate/CHARTS-11939-access-dialog
  1. Resolve conflicts:
edit ...
git add ...
git commit
  1. Push changes to upstream repository, Weblate will fetch merge from there:
git push origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants