Skip to content

ci: BI-0 move from pull_request_target to pull_request event #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: BI-0 move from pull_request_target to pull_request event #1322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ concurrency:
cancel-in-progress: true

on:
# Subject to change back to pull_request when we have a better solution for the CI with forked PRs
pull_request_target: # zizmor: ignore[dangerous-triggers]
pull_request:
types:
- opened
- reopened
Expand Down Expand Up @@ -46,8 +45,6 @@ jobs:
EVENT_NAME: ${{ github.event_name }}
EVENT_ACTION: ${{ github.event.action }}
run: |
[[ $EVENT_NAME != "pull_request_target" ]] && exit 0

action=$EVENT_ACTION
[[ $action == "labeled" || $action == "unlabeled" || $action == "opened" ]] && exit 0

Expand Down Expand Up @@ -164,8 +161,7 @@ jobs:
env:
REPO_OWNER: ${{ github.repository_owner }}
REPO_NAME: ${{ github.event.repository.name }}
# if pull_request_target use head sha, otherwise use github.sha
GIT_SHA: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.sha }}
GIT_SHA: ${{ github.sha }}

router:
runs-on: [ self-hosted, linux, k8s-runner-no-compose ]
Expand Down