DOS and disk operations refactoring; faster loads #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: symbolic consts, structs, routine names, extra DOS init; * asm object size warnings (there shall be overruns); Both FileMan and RWTS disk format currently work (on my testbeds), controlled by USE_RWTS_FORMAT symbol in diskload2.s
…erl (-dep); friendly 6502 addresses
…8000 where the loaded checksum byte is the last byte on a page (endload=$xx00, checksum at $xxFF), and the checksum algo incorrectly consumes an extra byte ($xx00) from the next page.
…s needs "b" fopen() mode for binary files read and write; POSIX will ignore "b".
…2t in place of hard-coded 6502 addresses.
…nes converted from .inc files; makes relocating the objects easier.
… object modifications
* High-level DOS code removed entirely; no FileMan; * Direct RWTS format(4) call; * ~9 seconds removed from the process.
…5 libs to avoid a make failure
…ing for which platform they were built)
… firmware protocol; * For safety of established user base, following the Principle of Least Surprise, the scan for controller starts with slot 6; slot 7 is skipped (unlike the IIe). Starting slot is easily adjustable.
…ifted by 1 page; add a warning for the future. (Interestingly, by the time diskload2 calls inflate for the very first time, the first page of diskload2 has served its purpose and never executes again. Inflate destroys the first page, but it is no longer needed, so this never surfaced in testing. It is possible to document the behavior as a "feature" instead and save 1 page of RAM.)
* conservatively set to 6,5,4 here, but can be any order, like 6,7,5,4,2.
…bytes; will need them later)
… unreliable seek to 0 after warm starts.
…xists that start_table (infdata) in diskload2 will cross page boundary, and padding to end of page should account for that.
…e time (formriting). Removes ~24 seconds from the "format" option diskload process. This is a fast variant, using self-modifying code, faithfully reproducing DOS timing.
…m). The bug would probably never surface because we cannot write to I/O pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all fixes along the way.