Skip to content

Conversation

@v-tarasevich-blitz-brain
Copy link
Contributor

This PR:

  • adds more generic ReloadableContext instead of ModulesContext to handle refreshing
  • adds refreshing of structured properties on update in entity sidebar (summary)
  • replaces using of ModulesContext with ReloadableContext

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025

Bundle Report

Changes will increase total bundle size by 1.07kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.59MB 1.07kB (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 1.07kB 18.93MB 0.01%

Files in assets/index-*.js:

  • ./src/app/entityV2/domain/DataProductsTab/CreateDataProductModal.tsx → Total Size: 2.08kB

  • ./src/app/entityV2/shared/components/styled/ExpandedOwner/ExpandedOwner.tsx → Total Size: 2.74kB

  • ./src/app/entityV2/shared/containers/profile/sidebar/Domain/SidebarDomainSection.tsx → Total Size: 3.26kB

  • ./src/app/domainV2/CreateDomainModal.tsx → Total Size: 6.83kB

  • ./src/app/entityV2/shared/containers/profile/sidebar/DataProduct/SetDataProductModal.tsx → Total Size: 5.53kB

  • ./src/app/entityV2/shared/entity/EntityActions.tsx → Total Size: 11.97kB

  • ./src/app/entityV2/shared/EntityDropdown/useDeleteEntity.tsx → Total Size: 3.13kB

  • ./src/app/entityV2/shared/containers/profile/sidebar/DataProduct/DataProductSection.tsx → Total Size: 3.27kB

  • ./src/app/entityV2/glossaryTerm/profile/AddRelatedTermsModal.tsx → Total Size: 6.22kB

  • ./src/app/entityV2/glossaryTerm/profile/useRemoveRelatedTerms.tsx → Total Size: 1.46kB

  • ./src/app/entityV2/shared/EntityDropdown/MoveDomainModal.tsx → Total Size: 2.88kB

  • ./src/app/homeV3/module/context/ModuleContext.tsx → Total Size: 962 bytes

  • ./src/app/entityV2/shared/containers/profile/header/EntityName.tsx → Total Size: 4.92kB

  • ./src/app/previewV2/utils.ts → Total Size: 6.17kB

  • ./src/app/govern/structuredProperties/StructuredPropsDrawer.tsx → Total Size: 12.08kB

  • ./src/app/sharedV2/reloadableContext/ReloadableContext.tsx → Total Size: 1.32kB

  • ./src/app/entityV2/shared/containers/profile/sidebar/Domain/SetDomainModal.tsx → Total Size: 6.07kB

  • ./src/app/AppProviders.tsx → Total Size: 943 bytes

  • ./src/app/entity/shared/EntityDropdown/CreateGlossaryEntityModal.tsx → Total Size: 8.64kB

  • ./src/app/shared/tags/AddTagsTermsModal.tsx → Total Size: 14.7kB

  • ./src/app/entityV2/shared/containers/profile/sidebar/Ownership/EditOwnersModal.tsx → Total Size: 11.83kB

  • ./src/app/entityV2/shared/sidebarSection/SidebarStructuredProperties.tsx → Total Size: 4.55kB

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title Vt ch 808 structured properties refresh properties on update feat(structuredProperties): refresh structured properties on update Oct 2, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title feat(structuredProperties): refresh structured properties on update [WAIT FOR CI] feat(structuredProperties): refresh structured properties on update Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
datahub-web-react/src/app/previewV2/utils.ts 33.33% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title [WAIT FOR CI] feat(structuredProperties): refresh structured properties on update feat(structuredProperties): refresh structured properties on update Oct 2, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain marked this pull request as ready for review October 2, 2025 13:32
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 2, 2025
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is making sense! i have a few questions on some of the details though

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 3, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-808-structured-properties--refresh-properties-on-update branch from 2621e5a to e98d9d8 Compare October 7, 2025 17:07
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 7, 2025
@github-actions github-actions bot requested a deployment to datahub-project-web-react (Preview) October 7, 2025 17:13 Abandoned
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 8, 2025

✅ Meticulous spotted 0 visual differences across 954 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 0d37973. This comment will update as new commits are pushed.

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-808-structured-properties--refresh-properties-on-update branch from e98d9d8 to 0d37973 Compare October 8, 2025 08:37
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we could probably have some stronger types to ensure folks use getReloadableKeyType when generating keys but this is nicer and don't need to block this moving forward

// ChildHierarchy - to reload shown child domains on asset summary tab
reloadModules([DataHubPageModuleType.ChildHierarchy], 3000);
reloadByKeyType(
[getReloadableKeyType(ReloadableKeyTypeNamespace.MODULE, DataHubPageModuleType.ChildHierarchy)],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change ReloadableKeyTypeNamespace to ReloadableKeyType

@chriscollins3456 chriscollins3456 merged commit 9992722 into master Oct 8, 2025
36 checks passed
@chriscollins3456 chriscollins3456 deleted the vt--ch-808-structured-properties--refresh-properties-on-update branch October 8, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants