fix(entity controller) Fix case sensitivity in entity controller

[zhixuanjia]

Issue Summary
Currently in the request body of createGenericEntities API , the entity name is passed in as camel case like FooBar but the entity type stored in DB is lowercase such as urn:li:foobar:123. This results in empty list in the response.

Fix
Perform case-insensitive matching on the result map key.

[codecov]

Bundle Report

Bundle size has no change ✅

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...roject/openapi/v3/controller/EntityController.java	0.00%	2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

[deepgarg760]

@zhixuanjia we can always check for lower case here ?
cc: @david-leifker

[RyanHolstien]

I agree that something about this feels off. Above we're setting the entries in the map to be the direct entityType from the urn (which should not be lowercase, it would be cased in the way the entity is defined, usually camelCase). Entity types are technically case sensitive (practically not, because of some auto lowercasing in entity registry, but not by the urn itself). I would expect consistency between how the keys are in the map are being set up and this code here. Either we should be consistently lowercasing them in the map above or it shouldn't need this lowercase call here (calling both of the getOrDefaults feels even weirder).

Would like to see tests exemplifying this case as well.

[zhixuanjia]

the urn (which should not be lowercase, it would be cased in the way the entity is defined, usually camelCase).

@RyanHolstien to provide some context here, we are not using the standard Datahub entity types like dataset, dataJob etc. Our models are loaded as plugins and they are all lowercased. And we use Open API spec to create Rest clients to interact with this endpoint. In the Open API spec, the entity names are from entity registry and they are in camelCases but entity types are all lowercased.

There are a few options we could fix this:

1. We could change all our entity types to camelCases to solve this issue but it's just too much work on our side. It will requires data migration.

2. We could also change the open api spec generator to use lowercases. But that will change the Rest client / interface which our other services have dependencies on.

3. Case-insensitive matching so that "FooBar" and "foobar" are considered the same entity type. This is the option used in this PR.

[RyanHolstien]

Hmm, wouldn't it make more sense for your entity types in the registry to be the same casing as it is for your actual entities? I.e. just change your plugin entity-registry.yml to match what the entities actually have. This kind of feels like putting customization specific code into the main OSS trunk the way you've described it 🤔

[RyanHolstien]

Suggested change

	List<IngestResult> entityResults = resultsByEntityType.getOrDefault(entityName, List.of());

Then remove this second check