Upgrade: Rails 7.1 → 7.2 & Ruby 3.1.7 → 3.2.9#79
Merged
Conversation
kaysiz
changed the title
jrhoads
reviewed
Jan 26, 2026
|
|
||
| # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies. | ||
| # config.force_ssl = true | ||
| config.force_ssl = true |
There was a problem hiding this comment.
In general this seems like a good idea but will this mess anything up? Does anything post to events directly? And does it use https?
Member
There was a problem hiding this comment.
Isn't the SSL layer provided by the load balancer? If it's expecting to connect internally to the containers on port 80 / without SSL, this could maybe cause an issue?
Member
There was a problem hiding this comment.
Oh wait, despite it saying REST API in the README, this is not actually the api.datacite.org/events endpoint and I just got confused 🫠
jrhoads
approved these changes
Jan 26, 2026
jrhoads
left a comment
jrhoads
left a comment
There was a problem hiding this comment.
I have the comment about SSL that I posted just a couple minutes ago, but if you are confident that I am A-OK going forward,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: