fix: add exponential recovery backoff#390
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #192.
This changes Rust stream creation and recovery retries from a fixed interval default to exponential backoff with full jitter.
recovery_backoff_msremains the fixed interval whenRetryStrategy::Fixedis selected, and becomes the base delay forRetryStrategy::ExponentialBackoffWithJitter;max_recovery_backoff_mscaps the computed exponential delay before jitter.The same retry helper is used by gRPC stream creation, Arrow Flight stream creation, and Arrow supervisor recovery sleeps so the behavior stays consistent across both stream implementations. The default strategy is now exponential backoff with jitter, so wrapper SDKs that rely on the Rust core inherit the safer retry behavior without new dependencies.
Verification
cargo fmt --manifest-path rust/sdk/Cargo.tomlcargo check -p databricks-zerobus-ingest-sdkcargo check -p databricks-zerobus-ingest-sdk --features arrow-flightcargo test -p databricks-zerobus-ingest-sdk --libcargo test -p databricks-zerobus-ingest-sdk --features arrow-flight --libgit diff --check