[Go] Add WithApplicationName method to SdkOption#357
Open
teodordelibasic-db wants to merge 2 commits into
Open
[Go] Add WithApplicationName method to SdkOption#357teodordelibasic-db wants to merge 2 commits into
WithApplicationName method to SdkOption#357teodordelibasic-db wants to merge 2 commits into
Conversation
teodordelibasic-db
changed the title
WithApplicationName method to SdkOption
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
teodordelibasic-db
force-pushed
the
go/user-agent
branch
from
147da23 to
ac8f34a
Compare
teodordelibasic-db
requested review from
a team,
andrijast-db,
danilonajkov-db,
davidtosovic-db,
elenagaljak-db and
irinatomic-db
Contributor
|
Maybe we should split the ffi changes and go changes? And do a separate ffi release? |
This was referenced Jun 17, 2026
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
UserAgentheader through theWithApplicationNamemethod toSdkOptionforNewZerobusSdk. Wire value becomeszerobus-sdk-go/<version> <application_name>.WithNoTLStoSdkOptionforNewZerobusSdkthat selects a no-TLS gRPC channel.user-agentheader now correctly identifies the Go SDK aszerobus-sdk-go/<version>instead of the underlying Rust default.How is this tested?
CI and testing against local server for propagation of the header.