fix gemini mcp registration to write to correct settings.json#155
Open
asujithan wants to merge 1 commit into
Open
fix gemini mcp registration to write to correct settings.json#155asujithan wants to merge 1 commit into
asujithan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
ucode configure mcpwould silently register Gemini MCP servers into afile the launcher never reads, so
/mcpinsideucode geminialwaysshowed "No MCP servers configured." even after a successful save.
add_gemini_mcp_server/remove_gemini_mcp_serverrangemini mcp add/removewithout settingGEMINI_CLI_HOME, so entries went to$HOME/.gemini/settings.json. Butagents/gemini.pylaunches Geminiwith
GEMINI_CLI_HOME=~/.ucode/.gemini-home, which makes the sessionread from a different settings.json. The two never intersected.
Fix: pin
GEMINI_CLI_HOMEto the samegemini.GEMINI_HOME_DIRforboth subprocess calls so registrations write to the file the launcher
reads.
Test plan
uv run ruff check src/ucode/mcp.py tests/test_mcp.pyuv run pytest tests/test_mcp.py(39/39)ucode configure mcp→ select an entry →ucode gemini→/mcplists the registered servers andtools/listworks.~/.ucode/.gemini-home/.gemini/settings.jsoncontains the newmcpServersentries;~/.gemini/settings.jsonis no longerwritten by ucode.