use modern imgui modifier key names#2525
Merged
jslee02 merged 2 commits intodartsim:mainfrom Mar 31, 2026
Merged
Conversation
given the whole `#if` block this resides in, this change _should_ be compatible even with "older" versions where `ImGuiKey_ModCtrl` was not yet removed but `ImGuiMod_Ctrl` already available
jslee02
approved these changes
Mar 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 433 433
Lines 38390 38390
Branches 5311 5310 -1
=======================================
Hits 34570 34570
Misses 3820 3820
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches over from
ImGuiKey_ModXXX(deprecated in 1.89) toImGuiMod_XXX. This should be backwards compatible (i.e. building with older imgui still works)Motivation / Problem
Building with imgui >= 1.92.6
Changes / Key Changes
ImGuiKey_ModXXX->ImGuiMod_XXXTesting
I sadly couldn't get pixi and/or this project's build tools set up, but it does build as the corresponding package in nixpkgs (which I'm trying to fixup in the first place)
Breaking Changes
none
Related Issues / PRs (backports)
release-6.16: use modern imgui modifier key names (6.16 backport) #2526 (files were renamed since then)Checklist
main, DART 6.16.x forrelease-6.16)