Skip to content

use modern imgui modifier key names#2525

Merged
jslee02 merged 2 commits intodartsim:mainfrom
jemand771:imgui-modifiers
Mar 31, 2026
Merged

use modern imgui modifier key names#2525
jslee02 merged 2 commits intodartsim:mainfrom
jemand771:imgui-modifiers

Conversation

@jemand771
Copy link
Copy Markdown
Contributor

@jemand771 jemand771 commented Mar 30, 2026

Summary

Switches over from ImGuiKey_ModXXX (deprecated in 1.89) to ImGuiMod_XXX. This should be backwards compatible (i.e. building with older imgui still works)

Motivation / Problem

Building with imgui >= 1.92.6

Changes / Key Changes

  • ImGuiKey_ModXXX -> ImGuiMod_XXX

Testing

I sadly couldn't get pixi and/or this project's build tools set up, but it does build as the corresponding package in nixpkgs (which I'm trying to fixup in the first place)

Breaking Changes

none

Related Issues / PRs (backports)


Checklist

  • Milestone set (DART 7.0 for main, DART 6.16.x for release-6.16)
  • CHANGELOG.md updated if required
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

given the whole `#if` block this resides in, this change _should_ be compatible even with "older" versions where `ImGuiKey_ModCtrl` was not yet removed but `ImGuiMod_Ctrl` already available
@jslee02 jslee02 enabled auto-merge (squash) March 31, 2026 14:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (81f98c5) to head (9296574).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2525   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         433      433           
  Lines       38390    38390           
  Branches     5311     5310    -1     
=======================================
  Hits        34570    34570           
  Misses       3820     3820           
Flag Coverage Δ
unittests 90.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 merged commit 4f4f999 into dartsim:main Mar 31, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants