Skip to content

Conversation

@rexthecoder
Copy link
Contributor

@rexthecoder rexthecoder commented Nov 10, 2025

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@rexthecoder rexthecoder requested a review from mosuem as a code owner November 10, 2025 17:11
@gemini-code-assist
Copy link

Summary of Changes

Hello @rexthecoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the intl package by enhancing the accuracy of currency symbol representation. Specifically, it addresses the Ghana Cedi (GHS) by replacing its generic textual representation with its official Unicode symbol. This change ensures that applications utilizing this package will display the correct and internationally recognized symbol for the Ghana Cedi, improving overall internationalization and user experience.

Highlights

  • Currency Symbol Correction: The pull request updates the currency symbol for the Ghana Cedi (GHS) to use its correct Unicode character.
  • Unicode Character Implementation: The GHS entry in the simpleCurrencySymbols map has been changed from the string 'GHS' to the Unicode character 'GH\u20B5'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the currency symbol for the Ghanaian Cedi (GHS) to use the correct Unicode character. My main feedback is to add a test case to verify this change, as required by the repository's contribution guidelines.

Update the currency symbol for Ghanaian Cedis (GHS) from "GHS" to "GH₵" (U+20B5) to use the correct currency symbol
@github-actions
Copy link

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
intl StringStack intl/date_format.dart::_DateFormatField::parse::input
intl/date_format.dart::_DateFormatField::parseLoose::input
intl/date_format.dart::_DateFormatField::parseLiteral::input
intl/date_format.dart::_DateFormatField::parseLiteralLoose::input
intl/date_format.dart::_DateFormatField::throwFormatException::stack
intl/number_parser_base.dart::NumberParserBase::input
intl/number_parser_base.dart::NumberParserBase::parseNumber::input
intl DateBuilder intl/date_format.dart::_DateFormatField::parse::dateFields
intl/date_format.dart::_DateFormatField::parseLoose::dateFields

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl None 0.20.2 0.20.3-wip 0.20.2 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ✔️
File Coverage
pkgs/intl/lib/src/intl/constants.dart 💚 100 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@brianquinlan brianquinlan merged commit 2d9c543 into dart-lang:main Nov 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants