-
Notifications
You must be signed in to change notification settings - Fork 58
refactor: update GHS currency symbol to use the correct Unicode character #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @rexthecoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the currency symbol for the Ghanaian Cedi (GHS) to use the correct Unicode character. My main feedback is to add a test case to verify this change, as required by the repository's contribution guidelines.
Update the currency symbol for Ghanaian Cedis (GHS) from "GHS" to "GH₵" (U+20B5) to use the correct currency symbol
PR HealthLicense Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| intl | StringStack | intl/date_format.dart::_DateFormatField::parse::input intl/date_format.dart::_DateFormatField::parseLoose::input intl/date_format.dart::_DateFormatField::parseLiteral::input intl/date_format.dart::_DateFormatField::parseLiteralLoose::input intl/date_format.dart::_DateFormatField::throwFormatException::stack intl/number_parser_base.dart::NumberParserBase::input intl/number_parser_base.dart::NumberParserBase::parseNumber::input |
| intl | DateBuilder | intl/date_format.dart::_DateFormatField::parse::dateFields intl/date_format.dart::_DateFormatField::parseLoose::dateFields |
This check can be disabled by tagging the PR with skip-leaking-check.
Breaking changes ✔️
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| intl | None | 0.20.2 | 0.20.3-wip | 0.20.2 | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ✔️
| File | Coverage |
|---|---|
| pkgs/intl/lib/src/intl/constants.dart | 💚 100 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.