Skip to content

Conversation

@japinli
Copy link
Contributor

@japinli japinli commented Jun 5, 2025

Hi,
When I build pgtt with PostgreSQL 18beta1:

pgtt.c: In function ‘create_temporary_table_internal’:
pgtt.c:1714:73: warning: passing argument 4 of ‘transformRelOptions’ from incompatible pointer type [-Wincompatible-pointer-types]
 1714 |                                                                         validnsps,
      |                                                                         ^~~~~~~~~
      |                                                                         |
      |                                                                         char **
In file included from pgtt.c:20:
/data/Codes/pg/master/build/pg/include/postgresql/server/access/reloptions.h:223:106: note: expected ‘const char * const*’ but argument is of type ‘char **’
  223 |                                                                  const char *namspace, const char *const validnsps[],
      |

It is because commit 1e35951e in PostgreSQL converts several 'validnsps' static variables into local variables and adds 'const' decorations to the signature of transformRelOptions(). This change results in a build warning regarding incompatible pointer types.

Commit 1e35951e in PostgreSQL converts several 'validnsps' static variables
into local variables and adds 'const' decorations to the signature of
transformRelOptions().  This change results in a build warning regarding
incompatible pointer types.
@darold darold merged commit be6fbca into darold:master Jun 5, 2025
5 checks passed
@darold
Copy link
Owner

darold commented Jun 5, 2025

Thanks!

@japinli japinli deleted the pgv18-warning branch June 6, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants