[osalyk]

This change is 

[janekmi]

@janekmi reviewed 4 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on osalyk).

---

.github/workflows/main.yml line 43 at r1 (raw file):

        run: |
          sudo pip install flake8
          sudo apt-get install clang-format

Probably not needed at all right now.

Suggestion:

          sudo apt-get install

---

utils/style_check.sh line 90 at r1 (raw file):

		return
	fi
	check_clang_version

Note this line is probably never reached anyway since I would expect there are no arguments for clang-format so this function exits early.

---

utils/style_check.sh line 91 at r1 (raw file):

		*.[ch]pp)
			CLANG_ARGS+="${ARGS[$i]} "
			;;

Since you excluded all C++ sources from cstyle we can either remove all of these utilites or none of them. I would argue if you decide to leave them I would also leave check_clang_version since when in use we would probably would like to have control over the clang-format version.

[osalyk]

@osalyk made 3 comments.
Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on janekmi).

---

.github/workflows/main.yml line 43 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Probably not needed at all right now.

All changes in #52

---

utils/style_check.sh line 90 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Note this line is probably never reached anyway since I would expect there are no arguments for clang-format so this function exits early.

.

---

utils/style_check.sh line 91 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Since you excluded all C++ sources from cstyle we can either remove all of these utilites or none of them. I would argue if you decide to leave them I would also leave check_clang_version since when in use we would probably would like to have control over the clang-format version.

.

[janekmi]

@janekmi reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on osalyk).