Repository navigation
Conversation
Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Ticket title is 'Hot-plugged drive claimed by the wrong engine' |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bdev_busid_range assumed PCI domain 0x0000 and only encoded an 8-bit
bus-ID range. On multi-PCI-segment platforms with non-zero domains,
this silently filtered the wrong bus-IDs (DAOS-19772: a hot-plugged
drive was claimed by the wrong engine).
Add bdev_hotplug_range, a config array of PCI domain + bus-ID-range
entries (one domain per entry; plain hex, no "0x" prefix, matching
ordinary PCI address formatting), replacing the legacy domain-0x00-
only bdev_busid_range (kept for backward compatibility). When unset,
ranges are now auto-derived directly from bdev_list's actual PCI
addresses instead of NUMA-node topology, collapsing only truly-
contiguous bus-IDs so the filter never admits an address absent from
bdev_list; VMD still allows all. Thread the resulting ranges through
to the SPDK JSON config and bio_config.c's hotplug_filter_fn, which
now matches domain+bus-ID per entry instead of a single bus-ID range.
Update daos_server.yml/admin guide to describe only the automatic
behavior; manual syntax is retained only in the design doc and
src/control/server/storage/README.md as an undocumented, experimental
escape hatch. Decimal notation is no longer accepted, hex only.
Add design/control/hotplug-pci-domain-design.md.
Features: control
Steps for the author:
After all prior steps are complete: