Fix memory issue (leak) for ngfDrop directive #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the event listeners added to the directive's element on scope $destroy.
Author
|
@danialfarid Please take a look. |
|
Yes please merge this pull request, I had the issue as well and this fixed it. Thanks for the fix @kovacsgezatamas btw :) 👍 |
|
great, just found this leak, please merge! |
|
yes, this leak should be fixed, please merge |
d-sko
added a commit
to d-sko/ng-file-upload
that referenced
this pull request
Jun 30, 2017
madflow
added a commit
to priotas/angular-file-upload
that referenced
this pull request
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the event listeners added to the directive's element on scope $destroy.