Repository navigation
fix(sign): detectSelfMint false-positive — redirect token after 'sidecar sign' misread as mint key - #433
Merged
Conversation
…car sign' misread as mint key A shell redirect token after `sidecar sign` was read as a mint key, so a routine `sidecar sign 2>/dev/null` / `sidecar sign >out` (bare list + redirect) was wrongly BLOCKED as SIGN-SELF-MINT (caught live on a `sidecar sign 2>&1` diagnostic). Root: segments() splits on unquoted `&`, so `2>&1` left rest[1]=`2>`, and any rest[1] not in the read-verb allowlist was treated as a mint key. Fix: a mint key must match /^[A-Za-z][\w-]*/ (a real word like rent/commons) — redirects/operators/empty fall through to ALLOW (bare list). Real mints (`sidecar sign rent`, `sudo sidecar sign rent`) still block; `sidecar sign check rent 2>&1` still allows (rest[1]=check). Follow-up to #432. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shell redirect token after
sidecar signwas read as a mint key, so a routinesidecar sign 2>/dev/null/sidecar sign >out(bare list + redirect) was wronglyBLOCKED as SIGN-SELF-MINT (caught live on a
sidecar sign 2>&1diagnostic). Root:segments() splits on unquoted
&, so2>&1left rest[1]=2>, and any rest[1] not inthe read-verb allowlist was treated as a mint key. Fix: a mint key must match
/^[A-Za-z][\w-]*/ (a real word like rent/commons) — redirects/operators/empty fall
through to ALLOW (bare list). Real mints (
sidecar sign rent,sudo sidecar sign rent)still block;
sidecar sign check rent 2>&1still allows (rest[1]=check). Follow-up to #432.Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com