fix(hy2): defer server resolution#65
Open
jiaming-shi wants to merge 1 commit into
Open
Conversation
Author
|
Fix daeuniverse/dae#982. 从 1.0.0 升级到 1.1.0 之后,hy2 节点无法正常使用,启动时报错: |
|
@jiaming-shi 试试2.0看看 |
Author
|
@olicesx 下载 v2.0.0rc1 测试,没有 hy2 节点的解析报错,不过代理整体看起来不工作了,直连是正常的。 v2.0.0rc1 在配置上有什么 breaking changes 吗? |
|
@jiaming-shi 你的hy2 格式是怎么样的,我正在用hy2 |
Author
完整配置文件是这个样子: |
Author
|
@olicesx 2.0.0rc1 验证没有问题,之前忘记把 auto_config_kernel_parameter 改成 true 了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The port-hopping change resolved hysteria2 hostnames in
NewDialer, so dae node loading could fail before dae DNS initialization finished.Validation
GOCACHE=/tmp/codex-go-cache GOMODCACHE=/tmp/codex-go-mod go test ./protocol/hysteria2 -run TestNewDialerDefersServerResolution -count=1