feat: add operational logs for node alive/dead transitions#1020
Closed
itoywh wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 18, 2026 15:54
- Add WARN log when node becomes DEAD in markUnavailableInternal - Add INFO log when node becomes ALIVE in markAvailable - Logs include node name and network type for easy debugging - Helps monitor node health and fixed_fallback behavior in production
…ery and improve health check disabled warning
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add operational logs for node status transitions (DEAD/ALIVE) to help monitor node health and fixed_fallback behavior in production.
Changes
1. Node became DEAD (WARN)
When a node transitions from alive to dead (via markUnavailableInternal), a WARN log with dialer and network fields is emitted:
WARN Node became DEAD dialer=s4 network=tcp4
2. Node became ALIVE (INFO) - Health check path
When health check probes detect a node has recovered (via markAvailable), an INFO log is emitted:
INFO Node became ALIVE dialer=s4 network=tcp4 latency=47ms
3. Node became ALIVE (INFO) - Traffic recovery path
When real user traffic successfully connects to a previously dead node (via markAvailableTraffic), an INFO log is emitted:
INFO Node became ALIVE (traffic) dialer=s4 network=tcp4
Motivation
In production, operators need visibility into node state transitions. Without these logs, a failed node silently gets deprioritized without any notification. The (traffic) suffix distinguishes between probe-detected recovery and actual traffic-detected recovery. This is especially useful for monitoring fixed_fallback behavior.