Repository navigation
Connect fork-point and branch headers to their anchor message - #238
Merged
Merged
Conversation
The fork-point box rendered with an 8px top gap below the message it hangs off (now visible as a landmark after #233), reading as a detached floating element. The branch headers floated similarly above their own content. Tie both to their anchors with a dashed top-border "connector" and a closed gap, while the .children indent still shows subordination: - .fork-point: top margin 8px → -1.2em (cancels the card's 1em bottom margin so it sticks up under the message above), border-top dashed, square top corners so the dashed edge reads as a connector tab. - .branch-header: bottom margin 1em → 0 (sticks to its branch content below), matching dashed top border. Snapshots regenerated (CSS is inlined into the HTML output); the diff is limited to these two rules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdates branch-header and fork-point CSS to add dashed top-border connectors, adjust spacing, and change fork-point corner rounding. Matching HTML snapshot fixtures were updated for the new rendered styles. ChangesBranch and fork connectors
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
For visual consistency: the fork-point has a squared top (where it connects up to the message above), so the branch header — which sticks to its own content below — should have a squared bottom (where it connects down). Round the top, square the bottom on .branch-header, and square its own fold-bar's bottom corners too (the fold-bar sits at the card's bottom edge, so its rounded corners would otherwise undo it). Snapshots regenerated (inlined CSS); diff limited to these rules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A visual follow-up to #233 (fork points whose node is an unrendered system message). Now that such a fork node renders as a landmark, the fork-point box — and the branch headers generally — read as detached floating elements with a gap above. This ties both to their anchor with a dashed top-border "connector" and a closed gap, while the
.childrenindent still shows subordination.Change (CSS only)
.fork-point(session_nav_styles.css): top margin8px → -1.2em(the negative margin cancels the.messagecard's1embottom margin, so the box sticks up under the message it hangs off),border-top: 1px dashed var(--fork-point-color),border-radius: 0 0 8px 8px(square top so the dashed edge reads as a connector tab)..branch-header(message_styles.css): bottom margin1em → 0(sticks the header to its own branch content below), matchingborder-top: 1px dashed var(--branch-point-color).No template / Python / JS change;
border-topis added to two existing rules, no new selectors. Affects all fork points and branch headers (every within-session rewind fork), intentionally. The fork-point box is still rendered inside.children, so it continues to fold away with its subtree.Testing
CSS is inlined into the HTML output, so the 8
test_snapshot_htmlsnapshots regenerated (updated serially with-n0per the CONTRIBUTING xdist-race warning). The.ambrchurn is limited to these two rules + their comments across the inlined copies — no message-HTML body changed.just cigreen (unit + TUI + browser + snapshots, ruff, pyright, ty); the browser fold-invariant test stays green.🤖 Generated with Claude Code
Summary by CodeRabbit