Claude/fix websocket timeout h gi xc - #5
Merged
Conversation
The ws.recv() call previously blocked indefinitely with no timeout, causing RunPod jobs to fail with "WebSocket message timeout after 60.0 seconds" on heavy workloads like video frame interpolation. - Add WEBSOCKET_MESSAGE_TIMEOUT env var (default 600s / 10 minutes) - Set ws.settimeout() after initial connect and after reconnect - On timeout, probe ComfyUI HTTP health before resuming the wait; fail fast if the server has become unreachable https://claude.ai/code/session_01TXa8rubsUoz56PV36fLRpS
On timeout, before deciding whether to keep waiting or fail, poll ComfyUI's /queue endpoint to check if the job is still actively running or pending. This matches the fix applied to the regular GPU server's generation_worker.py. Timeout handler now follows this decision tree: 1. ComfyUI HTTP unreachable → fail immediately 2. Job still in /queue (running/pending) → continue waiting 3. Queue check failed (network blip) → continue (benefit of doubt) 4. Job NOT in queue and NOT completed → fail with clear error https://claude.ai/code/session_01TXa8rubsUoz56PV36fLRpS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issues closed