Forbid non-numeric input to be treated as an integer#99
Open
lorcan wants to merge 2 commits intocypriss:masterfrom
Open
Forbid non-numeric input to be treated as an integer#99lorcan wants to merge 2 commits intocypriss:masterfrom
lorcan wants to merge 2 commits intocypriss:masterfrom
Conversation
lorcan
force-pushed
the
lorcan/failing-test
branch
from
abec60a to
1a37c2d
Compare
Contributor
Author
|
I've added a second commit to add logic to forbid non-numeric input to be treated as an integer. I'll squash these if we're going to merge it. |
lorcan
changed the title
This implements the solution discussed in cypriss#83 (comment)
lorcan
force-pushed
the
lorcan/failing-test
branch
from
1a37c2d to
d68c093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a failing case to demonstrate #83. I've written up some thoughts as to how to best handle that here.