Skip to content

Conversation

@ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Dec 1, 2025

Additional details

The existing error when the cy.prompt bundle is prematurely deleted off disk is less than helpful. It's also possible that we are deleting the bundle while other Cypress instances are accessing it. This PR:

  • Updates the error message to provide more guidance about what to do if the cy.prompt bundle is no longer properly available
  • Ensures that writes for the bundles are done atomically so there is no chance of code being stomped on.

Steps to test

How has the user experience changed?

PR Tasks


Note

Make Cloud bundle downloads/extraction atomic and add clearer cy.prompt error handling, with tests and changelog updates.

  • Cloud Bundles (Server):
    • Introduce extractAtomic to extract tar entries atomically using write-file-atomic.
    • Update ensure_cy_prompt_bundle and ensure_studio_bundle to download to a unique bundle.tar-* temp file and atomically extract to the target directory; clean up temp file afterward.
    • Add dependency [email protected].
    • Add comprehensive unit and integration tests for extractAtomic and update bundle ensure specs accordingly.
  • Driver / Errors:
    • Wrap cy.prompt remote init/load in try/catch; on failure, throw prompt.promptBundleNeedsRefresh.
    • Add new error message promptBundleNeedsRefresh in error_messages.ts.
  • Docs/Changelog:
    • Update CHANGELOG.md with bugfix entry for atomic Cloud bundle writes and improved cy.prompt() error message.

Written by Cursor Bugbot for commit 8c10e75. This will update automatically on new commits. Configure here.

@ryanthemanuel ryanthemanuel self-assigned this Dec 1, 2025
@cypress
Copy link

cypress bot commented Dec 1, 2025

cypress    Run #67680

Run Properties:  status check passed Passed #67680  •  git commit 8c10e75f04: cursor comment
Project cypress
Branch Review ryanm/chore/slight-refactor-for-ensuring-bundles
Run status status check passed Passed #67680
Run duration 19m 25s
Commit git commit 8c10e75f04: cursor comment
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 10
Tests that did not run due to a developer annotating a test with .skip  Pending 1097
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26698
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.61%
  Untested elements 187  
  Tested elements 161  
Accessibility  98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

@ryanthemanuel ryanthemanuel changed the title chore: refactor cy.prompt/studio bundle code downloads fix: concurrent cy.prompt() and Studio bundle download issues Dec 1, 2025
@ryanthemanuel ryanthemanuel requested a review from mschile December 1, 2025 23:37
@ryanthemanuel ryanthemanuel merged commit 7b46b9b into develop Dec 2, 2025
91 of 93 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/chore/slight-refactor-for-ensuring-bundles branch December 2, 2025 16:26
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 2, 2025

Released in 15.7.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v15.7.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants