Skip to content

Conversation

cyjake
Copy link
Owner

@cyjake cyjake commented Sep 16, 2025

att

@cyjake cyjake requested a review from Copilot September 16, 2025 05:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where bigint columns in cartesian product joins might be returned as strings, causing strict equality comparisons to fail when checking for duplicate primary keys.

  • Changes strict equality (===) to loose equality (==) for primary key comparison in join operations
  • Adds explanatory comments about the bigint/string conversion issue with MySQL's supportBigNumbers option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.77%. Comparing base (d14ae63) to head (0ebe597).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          45       45           
  Lines        3719     3719           
  Branches       73       73           
=======================================
  Hits         3599     3599           
  Misses        106      106           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyjake cyjake merged commit 783d843 into master Sep 16, 2025
6 checks passed
@cyjake cyjake deleted the fix-join-mapping branch September 16, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants